Support alternate gating methods#1215
Merged
Merged
Conversation
jb3
requested review from
MrHemlock and
fiskenslakt
and removed request for
a team
MarkKoz
requested changes
Oct 5, 2020
ghost
added
s: waiting for author
MarkKoz
added
a: moderation
ghost
added
needs 2 approvals
and removed
s: waiting for author
lemonsaurus
approved these changes
Oct 5, 2020
Contributor
lemonsaurus
left a comment
lemonsaurus
left a comment
There was a problem hiding this comment.
Looks great overall. Couple nitpicks, but nothing that needs to block merge. fix if you want.
MarkKoz
requested changes
Oct 5, 2020
ghost
added
s: waiting for author
ghost
added
needs 1 approval
and removed
s: waiting for author
MarkKoz
approved these changes
Oct 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the verification cog to support users joining through alternate gating methods.
It will send a separate DM for any user verifying through a gating method which is not
!acceptand will completely disable the welcome DM.